fix(vllm-performance): propagate package dependencies into Ray worker runtime environment - #1264
fix(vllm-performance): propagate package dependencies into Ray worker runtime environment#1264mgazz wants to merge 11 commits into
Conversation
|
You're now starting to get a multitude of packages to be passed down to the runtime env of the task. I believe you might also need to pass down the vllm version (see #1214), so I'm wondering whether it's best to drop this per-package approach and just merge the dictionaries and optionally guard against passing down certain packages (basically having an opt-out approach instead of opt-in) |
bb2db27 to
1493a83
Compare
ray package dependency into Ray worker runtime environment|
Following @AlessandroPomponio suggestion I went for a compromise. I kept the same control for target packages (ray, vllm, guidellm) and generalised the way we set dependencies in the runtime environment. |
There was a problem hiding this comment.
Setting the following in the remote.yaml
fromPyPI:
- ray==2.55.1
- vllm[bench]==0.24.0
Generates a test environment with the following dependencies
(VLLMPerformanceTest pid=13618, ip=10.129.26.19) 2026-07-23 08:21:03,246 DEBUG AsyncIO Thread: default ado_actuators.vllm_performance.actuator: submit : Experiment (test-agentic-tool-calling) - Ray task environment: {'uv': ['${RAY_RUNTIME_ENV_CREATE_WORKING_DIR}/ado_core-2.0.1.dev44+g4d2dce39.d20260723151103.dirty-py3-none-any.whl', '${RAY_RUNTIME_ENV_CREATE_WORKING_DIR}/ado_vllm_performance-1.9.7.dev42+g4d2dce39.d20260723151103.dirty-py3-none-any.whl[vllm]', 'ray==2.55.1', 'vllm[bench]==0.24.0']}
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
…prevent substring cross-match Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
…l dependencies the same way Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
…allback to unpublished dev version Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
…ckage_specs_from_job_env Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
…m fallback pinning Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
8f1a1d9 to
492d1e9
Compare
…s_from_job_env Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
This pull request adds propagation of the
raypackage dependency from the job environment into the Ray worker's runtime environment.Previously, only
ado-vllm-performanceandado-corewere extracted from the job environment; nowrayitself is also extracted and explicitly included in the worker dependencies, ensuring version consistency between the job environment and the Ray workers.Fixes #1257