Skip to content

Feature/club member#60

Open
devDav65 wants to merge 1 commit into
devfrom
feature/club_member
Open

Feature/club member#60
devDav65 wants to merge 1 commit into
devfrom
feature/club_member

Conversation

@devDav65

Copy link
Copy Markdown
Collaborator

No description provided.

@devDav65 devDav65 requested a review from SevTify404 April 20, 2026 10:35

@SevTify404 SevTify404 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mauvaise branche de destination

La branche de destination doit etre dev

@devDav65 devDav65 changed the base branch from main to dev April 20, 2026 12:39
logger.info(f"Utilisateur {user_id} a quitté le club {club_id} avec succès")
return ServiceResult.service_success(
data={"message": msg.MEMBER_DELETE_SUCCESS},
status_code=200,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enleve ce dictionnaire brute, il y'a des modeles pydantic spécial pour çà dans schemas/global_schemas, ici (dans le service) tu vas utiliser StringMessage et dans le router tu utilises GlobalStringMessage

logger.info(f"Membre {member_id} supprimé du club {club_id} avec succès")
logger.info(f"Membre {member_id} retiré du club {club_id} avec succès")
return ServiceResult.service_success(
data={"message": msg.MEMBER_DELETE_SUCCESS},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enleve ce dictionnaire brute, il y'a des modeles pydantic spécial pour çà dans schemas/global_schemas, ici (dans le service) tu vas utiliser StringMessage et dans le router tu utilises GlobalStringMessage

@SevTify404 SevTify404 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enleve les retours dans les services avec des dictionnaire brute, il y'a des modeles pydantic spécial pour çà dans schemas/global_schemas, dans le service tu vas utiliser StringMessage et dans le router tu utilises GlobalStringMessage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants