Skip to content

(Try to) Fix HyperLine on Hyper 2#161

Open
NTag wants to merge 2 commits into
Hyperline:masterfrom
NTag:fix-react
Open

(Try to) Fix HyperLine on Hyper 2#161
NTag wants to merge 2 commits into
Hyperline:masterfrom
NTag:fix-react

Conversation

@NTag

@NTag NTag commented Jun 17, 2018

Copy link
Copy Markdown

Try to make HyperLine work on Hyper 2 (cf. #159 and #160):

  • React is now bundled as a dependency, as it should be;
  • Using hyper/component is deprecated, use React.Component instead;
  • Remove prop-types from devDependencies (already present in dependencies).

Works with Hyper 2.1.0-canary.2 on macOS 10.13.

@lexdevelop

Copy link
Copy Markdown

Just try it with Hyper 2.1.0-canary.2 on Ubuntu 18.04, not working :(

@liloow

liloow commented Aug 4, 2018

Copy link
Copy Markdown

Used your pull request as boilerplate and added the code I mentioned in #163

Hyper@latest (canary)
Arch

Never had any issues
screencap

@jpmckearin

Copy link
Copy Markdown

@liloow can you upload that to a fork?

@liloow

liloow commented Aug 13, 2018

Copy link
Copy Markdown

@jpmckearin Sorry I was on vacation last week : fork
Tested on Arch

EDIT: Added custom dist (sorry for my oversight 😁) and custom branch with that ugly global.onload properly coded and a couple other details (this means core file have been modified hence the new branch)

@thiamsantos thiamsantos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, work on Mint 18 with Hyper 2.1.0-canary.2

@NTag thanks! 🎉 🎉

@lexdevelop

Copy link
Copy Markdown

Tested again Hyper 2.1.0-canary.2 on Ubuntu 18.04 with https://github.com/liloow/hyperline and works perfect, thank you.

@charles4221

Copy link
Copy Markdown

Any ideas on when this will be merged in? Currently, Hyperline is unusable on Hyper 2.1.0 on MacOS because of these deprecations.

@Sly777

Sly777 commented Dec 22, 2018

Copy link
Copy Markdown

Is there any plan to merge this?

@v1rtl

v1rtl commented Sep 21, 2019

Copy link
Copy Markdown

Had to delete hyperline bcoz of annoying deprecation messages. Please merge it someone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants