fix(app): prevent unpause from 'p' release event - #1
Merged
Conversation
Owner
|
Thanks for the contribution. This is a clean fix for a real cross-platform input bug. Really appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where the program could unpause unexpectedly - after a short delay - when running in Windows CMD.
Windows CMD also sends a key release event (
event::KeyEventKind::Release) which was being matched by theKeyCode::Char('p')arm.Changes
KeyCode::Char('p')match arm so that pausing requires a press event (event::KeyEventKind::Press) to trigger.Verification
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all-targets --all-featuresNotes
I moved the
ifcheck inside the match arm to allow for any future key hold behavior. However, this could also be placed directly below theif letstatement instead, since the other keys just quit the program.