Skip to content

Added HOARD_CONFIG env variable to specify config file - #347

Open
seivan wants to merge 1 commit into
Hyde46:mainfrom
seivan:feature/config_env
Open

Added HOARD_CONFIG env variable to specify config file#347
seivan wants to merge 1 commit into
Hyde46:mainfrom
seivan:feature/config_env

Conversation

@seivan

@seivan seivan commented Jul 11, 2024

Copy link
Copy Markdown

HOARD_CONFIG can point to a file path or a directory path where the file name would default to config.yml

export HOARD_CONFIG="~/.zsh/config/plugins/hoard_config.yml"
  • Added shellexpand dependency.
  • Expand tilde and variables for trove_path when reading config.trove_path
  • Removed duplicate construction for HoardConfig.
  • Added tests for reading env variable and making sure files are there.
  • Split up reading path and creating files at paths.

Fixes: #346

@seivan
seivan force-pushed the feature/config_env branch from 7e52537 to 3d3d232 Compare July 11, 2024 04:54
@seivan
seivan force-pushed the feature/config_env branch from 3d3d232 to e9391d4 Compare July 11, 2024 04:59
@Hyde46 Hyde46 assigned Hyde46 and seivan and unassigned Hyde46 Jul 11, 2024
@Hyde46
Hyde46 self-requested a review July 11, 2024 17:59
@Hyde46

Hyde46 commented Jul 11, 2024

Copy link
Copy Markdown
Owner

Thanks a lot for the contribution!
Ill take a closer look and review this as soon as possible

@seivan seivan changed the title Added HOARD_CONFIG env variable to specify config file Added HOARD_CONFIG env variable to specify config file Jul 11, 2024
@Hyde46

Hyde46 commented Jul 21, 2024

Copy link
Copy Markdown
Owner

Could you add this functionality to the Readme?
otherwise im happy to merge

@seivan

seivan commented Nov 12, 2024

Copy link
Copy Markdown
Author

@Hyde46 Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow changing location of config.yml using env variable

2 participants