Mineclone 2 compatibility and bug fixed - #2
Open
wuniversales wants to merge 6 commits into
Open
Conversation
HybridDog
reviewed
Mar 24, 2020
| -- Edited by Jasper den Ouden (a few commits now) | ||
|
|
||
| dofile(minetest.get_modpath("painting").."/crafts.lua") | ||
| dofile(minetest.get_modpath(minetest.get_current_modname()).."/crafts.lua") |
Owner
There was a problem hiding this comment.
This mod needs to be called painting because other mods may have painting in their dependency list, so you can assume that the current mod name does not change. I think it is better to crash than use a mod with wrong name.
Author
There was a problem hiding this comment.
I prefer automatic, since if you download it on github it is renamed to painting-master...
Owner
There was a problem hiding this comment.
Renaming the folder is mentioned at the official installation instructions: https://wiki.minetest.net/Help:Installing_Mods
The mod probably does not work if it has another name because of how the nodes and similar things are registered.
Edit: I've applied all changes except this one for now.
HybridDog
reviewed
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.