Repository navigation
fix(better): PageSpeed findings, main landmark, logo size, cache lifetimes and COOP - #35
Merged
Merged
Conversation
…times and COOP - index-better and stability-better get a <main> landmark (accessibility) - the logo has width and height on the three better pages (layout shift) - docker/librespeed-headers.conf: 30 days for fonts and images, 1 day for js, css and locales, none for the json an operator edits; COOP same-origin and nosniff. Installed in the Debian and Alpine images
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PageSpeed Insights of better.hdl.hv4.xyz (Performance 98, Accessibility 98, Best Practices 96).
<main>landmark on the speed test and stability pages (the route page had it)width/heighton the logo of the three better pagesdocker/librespeed-headers.conf, Debian and Alpine): cache of 30 days for fonts and images, 1 day for js, css and locales;settings.json,server-list.jsonandconfig.jsonare not cached;Cross-Origin-Opener-Policy: same-originandX-Content-Type-Options: nosniffNot done on purpose: strong CSP (inline handlers), X-Frame-Options (the pages are embeddable), HSTS (belongs to the reverse proxy), deferring the scripts and minifying (bigger change). The CORS console error comes from a third-party server of the public list.
Tests: better-pages, better-panel and better-hrs checked on the built image and on the Vördemo.