feat: batch_rhs (multi-RHS MatMatSolve) + adaptive_sweep#5
Merged
Conversation
batch_rhs: per frequency, assemble all excitations' RHS and apply the stored factorization in one MatMatSolve (BLAS3) instead of one triangular solve per antenna — measured 2.9-6.2x on the solve phase standalone. Direct preonly solves only; auto-disabled under sweep_mode/iterative. adaptive_sweep: error-controlled frequency sampling — seed solves, greedy largest-gap refinement with per-solve prediction verification (2 consecutive under tol ends the sweep), cubic-spline interpolation of the remaining S rows. S-parameters only; skipped frequencies store no fields. Worst case degrades to solving all frequencies, never to wrong answers. Both opt-in via solver_settings; default behavior unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two opt-in solver_settings features, validated end-to-end (bench/V2-RESULTS-2026-07-14.md):
Headline at 2.26M DOFs / Nf=22 / 3 antennas / 8 ranks, same box: stock LU 1,473 s / 19.6 GB → LDLT+batch+adaptive 285 s / 11.6 GB (5.2×); fp32 stack + adaptive = 843 s / 5.9 GB (0.30×). Cableport regression PASS; defaults unchanged (both features off unless requested).
🤖 Generated with Claude Code