fix: miepython 3.x compatibility in Mie far-field comparisons#2
Merged
Conversation
miepython >=3.0 returns 1-element arrays where 2.x returned scalars, breaking 'mies[i] = miepython.i_per(...)' with 'setting an array element with a sequence' in testSphereScattering/calcFarField. np.squeeze() makes all six call sites work under both API generations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miepython >=3.0 returns 1-element arrays where 2.x returned scalars, crashing the Mie-comparison path (testSphereScattering / calcFarField / convergence tests) — this is the breakage a reviewer hit and hand-patched locally. np.squeeze on the six call sites restores compatibility with both API generations. Verified by rerunning the Mie sphere test in the bench image (miepython 3.2.0).
🤖 Generated with Claude Code