Fix LadybugDB migration issues and JSON parsing#304
Closed
HumanBean17 wants to merge 1 commit into
Closed
Conversation
- Fix test file references from kuzu to ladybug (kuzu_db_path_cross_service_smoke → ladybug_db_path_cross_service_smoke) - Fix stale ontology tests to use ladybug.Connection instead of kuzu.Connection - Fix database file extension (.kuzu → .lbug) - Fix helper functions in _builders.py (build_kuzu_to → build_ladybug_to) - Add _parse_ladybug_json helper to handle LadybugDB's non-standard JSON format (unquoted keys) - Update meta() method to use _parse_ladybug_json for all JSON fields - Update error messages and CLI arguments from kuzu to ladybug - Fix test assertions to use ladybug_path instead of lbug_path - Fix test constant references (KUZU_INCREMENTAL_TRACKING_ISSUE_URL → LADYBUG_INCREMENTAL_TRACKING_ISSUE_URL) - Fix test assertions for LadybugDB warning messages - Add _parse_ladybug_json helper to test_ast_graph_build.py Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
Closing in favor of #303 — fixes pushed directly to that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix remaining issues from the KuzuDB → LadybugDB migration that were causing CI failures (exit code 139 segfaults) and test failures.
Root Causes Fixed
tests/test_ladybug_queries.pystill usedkuzu.Connectionand created.kuzudatabases, which crashed when opened with LadybugDB code{key: value}), but code usedjson.loadswhich expects standard JSONChanges
Core fixes:
_parse_ladybug_jsonhelper to handle LadybugDB's non-standard JSON formatmeta()method to use helper for all JSON fields_open_stale_ontology_graphto useladybug.Connectionand.lbugextensionkuzu_db_path_cross_service_smoke→ladybug_db_path_cross_service_smoke)_builders.py(build_kuzu_to→build_ladybug_to)Test updates:
_parse_ladybug_jsontotest_ast_graph_build.pyKUZU_INCREMENTAL_TRACKING_ISSUE_URL→LADYBUG_INCREMENTAL_TRACKING_ISSUE_URL)lbug_path→ladybug_path)Documentation/CLI:
--kuzu-pathto--ladybug-pathTest Results
test_ladybug_graph_refuses_ontology_version_below_requiredtest_find_route_callers_includes_producer_callerstest_find_route_callers_returns_route_caller_client_nodetest_trace_request_flow_inbound_includes_caller_node_idtest_metatest_graph_meta_present_and_versionedtest_ladybug_path_derived_as_index_dir_code_graph_kuzutest_increment_emits_kuzu_stale_warning_blocktest_increment_vectors_only_skips_graph🤖 Generated with Claude Code