fix(recipe): reject non-finite values for declared float recipe settings - #233
Open
HeaTTap wants to merge 3 commits into
Open
fix(recipe): reject non-finite values for declared float recipe settings#233HeaTTap wants to merge 3 commits into
HeaTTap wants to merge 3 commits into
Conversation
|
Merge Oncall: @BobbyZhouZijian The merge oncall will route reviews and keep this pull request moving toward a clear decision. |
Contributor
|
Hi @HeaTTap , thanks for the PR. Could you resolve the CI failures? |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #225
Rejects NaN, positive infinity, and negative infinity for declared float recipe settings so invalid values fail fast during configuration resolution rather than silently altering sampling or blocking waits downstream.
Changes
Compatibility and operational impact
None. Declared float recipe settings require finite numbers.
Verification
Ran:
AI assistance
None
Checklist