Skip to content

feat(i18n): add Korean (ko) translation#235

Open
moduvoice wants to merge 2 commits into
HugoRCD:mainfrom
moduvoice:i18n/add-korean-translation
Open

feat(i18n): add Korean (ko) translation#235
moduvoice wants to merge 2 commits into
HugoRCD:mainfrom
moduvoice:i18n/add-korean-translation

Conversation

@moduvoice

@moduvoice moduvoice commented Jun 13, 2026

Copy link
Copy Markdown

🔗 Linked issue

📚 Description

Adds a Korean (ko) locale to Canvas.

  • New i18n/locales/ko/{global,navigation,contact,writing}.json — all keys translated from the English source (full parity, nested contact.subject_types included).
  • Registered in i18n/locales/messages.ts (imports + ko block).
  • Added { code: 'ko', name: 'Korean', language: 'ko-KR' } to i18n.locales in nuxt.config.ts, and /ko to the Nitro prerender routes so the Korean pages are statically generated like /en and /fr.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • New Features
    • Added full Korean language support: translations for navigation, contact form, global UI, and writing/articles. Korean is now selectable across the app and site routes have been updated to include Korean, enabling complete localization for Korean-speaking users.

Add Korean locale files (i18n/locales/ko/{global,navigation,contact,writing}.json),
register them in i18n/locales/messages.ts, and add the ko locale to nuxt.config.ts
(i18n.locales + prerender routes).
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

Thank you for following the naming conventions! 🙏

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dcae0c88-5ea6-4a4c-a6eb-db66e3395940

📥 Commits

Reviewing files that changed from the base of the PR and between 66222b2 and 42de0b7.

📒 Files selected for processing (1)
  • i18n/locales/ko/writing.json

📝 Walkthrough

Walkthrough

Adds Korean locale support: four new i18n/locales/ko/*.json translation files, registers them in i18n/locales/messages.ts, and updates nuxt.config.ts to include the ko locale and /ko prerender route.

Changes

Korean locale support

Layer / File(s) Summary
Korean locale translation files
i18n/locales/ko/navigation.json, i18n/locales/ko/contact.json, i18n/locales/ko/global.json, i18n/locales/ko/writing.json
Four new JSON files define complete Korean translations for navigation labels, contact form fields and submit states, global UI strings, and writing page metadata and controls.
Locale registration and build configuration
i18n/locales/messages.ts, nuxt.config.ts
Korean locale files are imported and exposed via the messages registry. Nuxt config adds the ko locale entry and /ko to the Nitro prerender routes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(i18n): add Korean (ko) translation' directly and clearly describes the main change—adding Korean locale support to the i18n system.
Description check ✅ Passed The description provides comprehensive details about the Korean locale addition, including file names, registration steps, and configuration changes. However, the linked issue and documentation checklist items are unchecked/incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@i18n/locales/ko/writing.json`:
- Line 8: The current localization key writing.readingTime contains "분 분량" which
duplicates the unit when rendered as "{{ page?.readingTime }} {{
$t('writing.readingTime') }}"; update the value of writing.readingTime to a
natural trailing unit/phrase that fits the "{number} {text}" pattern such as "분
소요" or "분 정도" so rendered output becomes e.g. "10 분 소요"; edit the
writing.readingTime entry accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6c7c05ef-c4c7-4bc0-988b-bd245bc7799a

📥 Commits

Reviewing files that changed from the base of the PR and between ad9c9ab and 66222b2.

📒 Files selected for processing (6)
  • i18n/locales/ko/contact.json
  • i18n/locales/ko/global.json
  • i18n/locales/ko/navigation.json
  • i18n/locales/ko/writing.json
  • i18n/locales/messages.ts
  • nuxt.config.ts

Comment thread i18n/locales/ko/writing.json Outdated
readingTime renders as a suffix after the minute count
({{ readingTime }} {{ $t('writing.readingTime') }}), so '분 분량' produced an
awkward, redundant '10 분 분량'. Use '분 읽기' to match the English/French intent
('mins to read' / 'min de lecture').
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant