feat(i18n): add Korean (ko) translation#235
Conversation
Add Korean locale files (i18n/locales/ko/{global,navigation,contact,writing}.json),
register them in i18n/locales/messages.ts, and add the ko locale to nuxt.config.ts
(i18n.locales + prerender routes).
|
Thank you for following the naming conventions! 🙏 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds Korean locale support: four new ChangesKorean locale support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@i18n/locales/ko/writing.json`:
- Line 8: The current localization key writing.readingTime contains "분 분량" which
duplicates the unit when rendered as "{{ page?.readingTime }} {{
$t('writing.readingTime') }}"; update the value of writing.readingTime to a
natural trailing unit/phrase that fits the "{number} {text}" pattern such as "분
소요" or "분 정도" so rendered output becomes e.g. "10 분 소요"; edit the
writing.readingTime entry accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6c7c05ef-c4c7-4bc0-988b-bd245bc7799a
📒 Files selected for processing (6)
i18n/locales/ko/contact.jsoni18n/locales/ko/global.jsoni18n/locales/ko/navigation.jsoni18n/locales/ko/writing.jsoni18n/locales/messages.tsnuxt.config.ts
readingTime renders as a suffix after the minute count
({{ readingTime }} {{ $t('writing.readingTime') }}), so '분 분량' produced an
awkward, redundant '10 분 분량'. Use '분 읽기' to match the English/French intent
('mins to read' / 'min de lecture').
🔗 Linked issue
📚 Description
Adds a Korean (
ko) locale to Canvas.i18n/locales/ko/{global,navigation,contact,writing}.json— all keys translated from the English source (full parity, nestedcontact.subject_typesincluded).i18n/locales/messages.ts(imports +koblock).{ code: 'ko', name: 'Korean', language: 'ko-KR' }toi18n.localesinnuxt.config.ts, and/koto the Nitro prerender routes so the Korean pages are statically generated like/enand/fr.📝 Checklist
Summary by CodeRabbit