Removes dependencies on unneeded Serverless Framework - #38
Conversation
DougReeder
added
dependencies
978a9ec to
4d8bbc7
Compare
There was a problem hiding this comment.
Left one question on the .gitignore changes, but otherwise everything looks good to me. This does conflict with PR #36, but I'll update that after this is merged.
One nit on the PR description: nearspark has already been checked off in Hubs-Foundation/hubs-cloud#384 so I don't think this PR is part of it?
EDIT 2026-07-29: Perhaps it is part of it since the hubs-cloud version did have serverless removed.
| .idea | ||
| image |
There was a problem hiding this comment.
Are the additions of .idea and image intended?
There was a problem hiding this comment.
Yes. I suppose they should be in a separate commit.
There was a problem hiding this comment.
Yeah, I think having the .gitignore changes not directly related to the serverless removal in a separate commit would be good.
Though I'm not sure about including image. Why was that added? It seems like it could be a valid folder name someone might pick in the future.
There was a problem hiding this comment.
* Updated/Clarified previous comment.
4d8bbc7 to
97772da
Compare
Exairnous
left a comment
Exairnous
left a comment
There was a problem hiding this comment.
@DougReeder Thank you for the update; however, your switch from using npm install to npm ci directly conflicts with PR #36. In light of this, can you please remove those changes? If you think that PR #36 would benefit from the use of the --production flag, I can add it.
97772da to
b601dfb
Compare
Exairnous
left a comment
Exairnous
left a comment
There was a problem hiding this comment.
Thank you for the update. LGTM. Merging.
2 participants
What?
Removes dependencies on unneeded Serverless Framework
Why?
This is now an Express.js app, not a serverless function, so the Serverless Framework is unneeded.
Compromised versions of axios exist. We don't use it directly, but Serverless Framework does.
Examples
No change to functionality
How to test
dougreeder/nearspark:remove-serverless-2026-07-17-22-53in a Hubs instance.kubectl set image deployment/nearspark nearspark=dougreeder/nearspark:remove-serverless-2026-07-17-22-53kubectl rollout restart deploy nearspark -n hcceDocumentation of functionality
No change in behavior.
Limitations
None
Alternative implementations considered
None
Open questions
None
Additional details or related context
Part of Hubs-Foundation/hubs-cloud#384