Conversation
What: converts the automatically called import/export draw function for Blender 4.2+ into two functions (one for import and one for export) and registers them specifically with the glTF add-on. Why: the glTF add-on changed how it handled registering the export panel in Blender 4.4+ in order to better accommodate collection exporters, so this accounts for the changes while still supporting previous versions and also enables the settings panels to be shown in the collection exporters. Notes: The import settings panel didn't technically need to be done this way, but it keeps it consistent with the export settings panel and hopefully helps to future proof it. This specifically doesn't use any of the automatically called function names (draw, draw_export, draw_import) in order to not conflict with previous versions of the glTF add-on and prevent any of the panels from being duplicated. Related glTF commits/PRs: KhronosGroup/glTF-Blender-IO@fae512b KhronosGroup/glTF-Blender-IO#2313 KhronosGroup/glTF-Blender-IO@49b5680
What: adds a string property to the HubsComponentsExtensionProperties group and displays it in the exporter settings to allow the user to specify what the GLB file was originally generated with, this is then be combined with what the current generator is (i.e. the glTF add-on) and written to the GLB file on export. Why: so that the provenance of the GLB file can be maintained when it is modified. Notes: This is mainly for the branding removal project[1], but may also be useful in general. The "Original Generator" property is stored on the scene and shared by all the different ways to export, so all exports within the scene (including any collection exporters) will share the one value. [1] https://docs.google.com/document/d/1bp2GInoMMae4q00gcxAAjmxVtL2hus-WO-YHhppeuvg/edit?tab=t.0
|
Thank you for the pull request. ROADMAP STATUS: This pull request isn't currently on any roadmap. Updates will be conveyed here as its place on/off a roadmap changes. You can view the roadmaps here: Roadmaps Google Drive folder. For more information on how the roadmaps work, see our roadmaps policy on GitHub. |
Member
Author
|
Added a zip of this PR that can be installed to the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds an export setting that allows you to specify the original generator of a GLB file.
Why?
So that the provenance of the GLB file can be maintained when it is modified.
Examples
Before:
After:
How to test
For versions of Blender that support collection exporters:
Documentation of functionality
If adopted, this will probably need documentation; however, since it is a very simple feature and at the moment it is mainly for use by a few people (that I will be in contact with) for the branding removal project, I'm not going to bother adding documentation at present. If we decide we want to include this in the main add-on, I will add the documentation before merging.
Known limitations
The "Original Generator" property is stored on the scene and shared by all the different ways to export, so all exports within the scene (including any collection exporters) will share the one value. Having separate values for each export location isn't supported as it isn't needed for the branding removal project. If separate values for each export location are desired, they can be added later (either in this PR or a separate PR).
Alternative implementations considered
None.
Open questions
Additional details or related context
This is mainly for the branding removal project, but may also be useful in general.
Note: this PR is based off of #353 After that PR is merged I will update this PR to remove the extraneous commit from #353
Installable zip of this PR
io_hubs_addon_1.8.0.596.zip