Skip to content

Ensure chunk get indexed when out of order with full length - #242

Merged
Bisaloo merged 2 commits into
develfrom
test-artur
Aug 21, 2026
Merged

Ensure chunk get indexed when out of order with full length#242
Bisaloo merged 2 commits into
develfrom
test-artur

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Aug 21, 2026

Copy link
Copy Markdown
Member

Fix #241

@Bisaloo
Bisaloo merged commit 4a6e987 into devel Aug 21, 2026
15 checks passed
@Bisaloo
Bisaloo deleted the test-artur branch August 21, 2026 22:15
@github-actions

Copy link
Copy Markdown

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 90ef77f is merged into devel:

  • ✔️create_groups: 7.71ms -> 7.72ms [-0.84%, +1.03%]
  • ✔️pkg_load: 233ms -> 234ms [-0.66%, +1.34%]
  • ❗🐌read_blosc_lz4: 145ms -> 146ms [+1.02%, +1.54%]
  • ✔️read_boolean: 6.58ms -> 6.44ms [-4.75%, +0.34%]
  • ❗🐌read_c_order: 9.03ms -> 9.16ms [+1.08%, +1.97%]
  • ✔️read_double: 8.72ms -> 8.64ms [-6%, +4.29%]
  • 🚀read_empty: 5.85ms -> 5.8ms [-1.41%, -0.32%]
  • ✔️read_float16: 7.89ms -> 7.89ms [-1.36%, +1.3%]
  • ✔️read_float32: 7.87ms -> 7.91ms [-0.14%, +1.28%]
  • ✔️read_int16: 7.89ms -> 7.84ms [-2.34%, +1.14%]
  • ❗🐌read_int32: 8.46ms -> 8.59ms [+0.93%, +2.11%]
  • ✔️read_int64: 8.61ms -> 8.59ms [-1.69%, +1.31%]
  • ❗🐌read_int8: 7.83ms -> 7.99ms [+0.2%, +3.84%]
  • ✔️read_lz4: 6.35ms -> 6.47ms [-0.6%, +4.63%]
  • ✔️read_sharded: 9.52ms -> 9.55ms [-0.29%, +0.79%]
  • ✔️read_string: 3.39ms -> 3.4ms [-0.51%, +1.02%]
  • ❗🐌read_uint32: 8.42ms -> 8.48ms [+0.04%, +1.51%]
  • ✔️read_uint64: 8.42ms -> 8.51ms [-0.22%, +2.27%]
  • ✔️read_unicode: 3.37ms -> 3.29ms [-5.79%, +0.82%]
  • ✔️read_vlen_utf8: 6.72ms -> 6.73ms [-1.2%, +1.4%]
  • ✔️read_zlib: 6.27ms -> 6.25ms [-0.98%, +0.47%]
  • ❗🐌read_zstd: 165ms -> 169ms [+1.97%, +2.43%]
  • 🚀write_blosc_lz4: 186ms -> 186ms [-0.43%, -0.04%]
  • ✔️write_bool: 9.36ms -> 9.37ms [-0.77%, +0.94%]
  • ✔️write_double: 21.3ms -> 21.4ms [-0.18%, +0.85%]
  • ✔️write_float32: 21.3ms -> 21.3ms [-0.73%, +0.58%]
  • ✔️write_int16: 21.3ms -> 21.5ms [-0.27%, +2.21%]
  • ✔️write_int32: 21.2ms -> 21.2ms [-0.29%, +0.59%]
  • ❗🐌write_int8: 10.7ms -> 10.7ms [+0.17%, +1.55%]
  • ✔️write_string: 8.99ms -> 9.04ms [-0.23%, +1.22%]
  • ✔️write_unicode: 8.6ms -> 8.62ms [-0.62%, +1.12%]
  • ✔️write_zstd: 214ms -> 214ms [-0.37%, +0.23%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

read_zarr_array sorts permuted full indices from index

1 participant