fix: Increase window to decode 13 byte payloads#26
Merged
Conversation
Previously, we decoded 1s windows of IQ samples, that were appended by 0.5s chunks. That chunk ended up being 0.55-0.58 seconds worth of chunks. This made it common for packets with 13 byte payloads to be missed if their preamble began in the very beginning of the chunk, because it would be cut off when the chunk was appeneded to the window. Increases the DECODE_INTERVAL_S to 0.6s, which more accurately reflects the amount that the window advances. Increases to deocde window to 1.5s so that longer packets don't get lost. The wider, overlapping window decodes one packet on multiple passes, so add strict content+time de-duplication: two decodes are merged only if device id, auth tag AND payload match and their start times are within 1 s. Genuinely distinct packets are never merged. Signed-off-by: hunterhubble <hunter@hubble.com>
Contributor
Author
|
Tested with our 5GA devices + ESP32C6, each device decoded 56/56 packets of 13 byte payloads |
HongNguyen635
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we decoded 1s windows of IQ samples, that were appended by 0.5s chunks. That chunk ended up being 0.55-0.58 seconds worth of chunks. This made it common for packets with 13 byte payloads to be missed if their preamble began in the very beginning of the chunk, because it would be cut off when the chunk was appeneded to the window.
Increases the DECODE_INTERVAL_S to 0.6s, which more accurately reflects the amount that the window advances. Increases to deocde window to 1.5s so that longer packets don't get lost.
The wider, overlapping window decodes one packet on multiple passes, so add strict content+time de-duplication: two decodes are merged only if device id, auth tag AND payload match and their start times are within 1 s. Genuinely distinct packets are never merged.