Sat scan improvements#22
Conversation
- Includes pdu_n_corr and header_n_corr as items of the packet, so we can see the RS corrections per packet Signed-off-by: hunterhubble <hunter@hubble.com>
Signed-off-by: hunterhubble <hunter@hubble.com>
hunterhubble
force-pushed
the
sat-scan-improve
branch
3 times, most recently
from
df81525 to
cbfc879
Compare
|
Sat Scan with warning line (error threshold was reduced to get it to display, it is not as low in the code currently) |
There was a problem hiding this comment.
Pull request overview
This PR improves satellite scan/debug visibility by deriving symbol/gap timing statistics from detected symbol edges, returning those stats alongside TD plot output, and exposing them in packet APIs.
Changes:
- Add
edges_to_timing_stats()helper to compute symbol/gap mean/std timing stats from corrected edges. - Update
render_td_plot()to prefer protocol-corrected edge timing (when decode metadata is available) and return(image_bytes, stats). - Include correlation counts and timing stats in
/api/packetsoutput.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/stream_web/timing.py |
Adds timing-stats helper for corrected symbol edge pairs. |
src/stream_web/spectrogram.py |
Enhances TD plot edge detection to use protocol-aware correction and returns stats with image bytes. |
src/stream_web/processor.py |
Computes per-packet timing stats and adapts to new TD plot return type, forwarding stats to the UI/API. |
src/stream_web/app.py |
Extends /api/packets JSONL output with correlation counts and symbol/gap timing stats. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What do you mean by "error threshold was reduced to get it to display"? Before we display this warning, we need to confirm what is the acceptable symbol & gap error / tolerance on the HDL side. This will raise many questions if end users start to see this. |
I can see how this is a concern, let me start a slack thread and I can explain why I chose these numbers |
hunterhubble
force-pushed
the
sat-scan-improve
branch
from
d14814f to
27e578d
Compare
|
@HongNguyen635 I sort of made a mistake with adding the screenshot to this PR, when the timing warning logic is only in pyhubblenetwork. The changes of this PR do not regard that one. If you could take a look when you have the chance I would appreciate it |
- Changed timing info to match what's found with zoomed in image - Also able to verify the timing correction by looking at zoom in - Purpose of this change is to make it so we only have to poll /packets to get all the information we need, because polling that and /td_info lagged the live spectrogram viewer Signed-off-by: hunterhubble <hunter@hubble.com>
hunterhubble
force-pushed
the
sat-scan-improve
branch
from
27e578d to
6b0c967
Compare
No description provided.