Sat scan improve#37
Conversation
hunterhubble
force-pushed
the
sat-scan-improve
branch
2 times, most recently
from
3dec12c to
3329e8c
Compare
hunterhubble
requested review from
HongNguyen635,
buckleypaul,
hubble-art and
mason-hubble
hunterhubble
force-pushed
the
sat-scan-improve
branch
2 times, most recently
from
dee9d66 to
2bd14fe
Compare
hunterhubble
force-pushed
the
sat-scan-improve
branch
2 times, most recently
from
52baeca to
2f30dc8
Compare
|
@HongNguyen635 I've made the symbol timing warning threshold 4ms based on Charles' advice, this can be subject to change if needed though. |
HongNguyen635
left a comment
HongNguyen635
left a comment
There was a problem hiding this comment.
do you also want add what Vamsi & Art said about the drift as well? I guess it kind of implicitly account for when you do average symbol time > 4.0 ms?
| if pkt.sym_mean_ms is not None and abs(pkt.sym_mean_ms - 8.0) > 4.0: | ||
| warnings.append(f"sym {pkt.sym_mean_ms:.2f} ms (expected 8.00)") |
There was a problem hiding this comment.
do we have this constant 8.0 and 4.0 somewhere? I feel like magic number like this is dangerous in which later on if the protocol change, we could forget what it means.
Maybe add constants and/or a comment explaining the reason behind 4.0 ms.
There was a problem hiding this comment.
Good point, my bad, that's not good practice
There was a problem hiding this comment.
@hunterhubble you forgot to update the numbers in these 2 lines with the constants?
|
@HongNguyen635 I think that the drift can still be valuable. The average timing could look fine but the drift could still be problematic at the same time. There are already several features in this PR, and I would also have to start another PR in sdr-docker to do so. I will definitely do that though. |
hunterhubble
force-pushed
the
sat-scan-improve
branch
from
2f30dc8 to
27de4a1
Compare
| # Symbol time tolerance. With our envelope detection, we can expect the symbol | ||
| # to be off by 1/2 of the length of the symbol before that envelope | ||
| # reads the adjacent symbol, Any deviation from the nominal 8ms will see a dB | ||
| #loss, but the frequency will be correct |
| if pkt.sym_mean_ms is not None and abs(pkt.sym_mean_ms - 8.0) > 4.0: | ||
| warnings.append(f"sym {pkt.sym_mean_ms:.2f} ms (expected 8.00)") |
There was a problem hiding this comment.
@hunterhubble you forgot to update the numbers in these 2 lines with the constants?
hunterhubble
force-pushed
the
sat-scan-improve
branch
2 times, most recently
from
559f86c to
f558aee
Compare
- Both timing and RS corrections only appear with --debug - Added total RS corrections (header + payload) to the table when you run 'hubblenetwork sat scan' per packet - Also added an optional --pluto-uri parameter to sat scan. This is heplful if a pluto device is passed over USB, I can add the flag '--pluto-uri :usb' - When using sat scan and providing a key, the average symbol length and gap length in ms will print in the row per packet decoded - If measured average symbol time is 1ms off nominal, or if the gap is 200us off nominal, print a warning line Coincides with commit 492f5b6 from sdr-docker Signed-off-by: Hunter Patchett <hunter@hubble.com>
hunterhubble
force-pushed
the
sat-scan-improve
branch
from
f558aee to
ad4a9fc
Compare
2 participants
feat: Add RS Corrections per packet
Both timing and RS corrections only appear with --debug
Added total RS corrections (header + payload) to the table
when you run 'hubblenetwork sat scan' per packet
Also added an optional --pluto-uri parameter to sat scan. This is heplful if
a pluto device is passed over USB, I can add the flag '--pluto-uri :usb'
When using sat scan and providing a key, the average symbol length and gap length
in ms will print in the row per packet decoded
If measured average symbol time is 4ms off nominal, print a warning
Coincides with commit 492f5b6 from sdr-docker