gnupg: add patch to work with pinentry-mac

[LinusU]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

As discussed in #68265 (comment) this adds the patch to GnuPG recommended by the GPGTools team to workaround for a bug in gpg-agent when a wrong password from the cache is returned by pinentry-mac.

[SMillerDev]

Has this patch been submitted upstream?

[LinusU]

I'm not sure.

@lukele do you know if anyone at GPGTools have submitted this upstream?

[lukele]

@SMillerDev @LinusU since this is only relevant for pinentry-mac (in combination with macOS Keychain as pin cache), not the general pinentry implementation, it was not. We have discussed it a few years ago, but there has not been any progress since.

[lukele]

Is it possible to have homebrew recognize MacGPG2 as installed version of gnupg so packages depending on gnupg don't have to install the gnupg package (creating a conflict)

[SMillerDev]

No, all packages that homebrew depends on must be installed using homebrew.

[lukele]

Ok, thanks. That's unfortunate.

[SMillerDev]

since this is only relevant for pinentry-mac (in combination with macOS Keychain as pin cache), not the general pinentry implementation, it was not. We have discussed it a few years ago, but there has not been any progress since.

If the goal is to upstream the pinentry modifications. Why not try and upstream this already?

[BrewTestBot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[lukele]

As has been reported on the GnuPG mailing list it appears that the old pinentry version did not cache passphrases in macOS Keychain. The new one does by default.

So you might want to add a patch which changes the following line from @YES to @NO in order to restore the previous default:
https://github.com/GPGTools/pinentry/blob/85b3564ea3976c48d62028ccba26c2ac3e5b0241/macosx/AppDelegate.m#L38

[BrewTestBot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.