vapoursynth-vszip 22.1.0 (new formula) - #298871
Merged
Merged
Conversation
p-linnane
approved these changes
Aug 14, 2026
Contributor
|
馃 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't meet notability but considering an exception to simplify
Zig makes it harder to pass our
-headerpad_max_install_names(usually don't see an issue as most Zig dependents are executables rather than libraries).Here the default
@rpath/...is actually okay to use since the library is a plugin loaded by VapourSynth so can usepreserve_rpath. Seemed safer to isolate this DSL usage to a separate formula and also allows scoping the Zig dependency, which is fragile and will keep breaking across releases until zig 1.0.The parent package that introduces dependency does meet our notability requirement: https://github.com/Jaded-Encoding-Thaumaturgy/vs-jetpack (just barely at 77 stars)
Also, loading VapourSynth plugins is a bit complicated and won't work correctly in virtualenv. We will likely need to add
VAPOURSYNTH_EXTRA_PLUGIN_PATHbut this only accepts a single path and a user may want to override this at runtime.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?