Skip to content

agent-manager 0.29.1 (new formula) - #298792

Open
YoanWai wants to merge 1 commit into
Homebrew:mainfrom
YoanWai:agent-manager
Open

agent-manager 0.29.1 (new formula)#298792
YoanWai wants to merge 1 commit into
Homebrew:mainfrom
YoanWai:agent-manager

Conversation

@YoanWai

@YoanWai YoanWai commented Aug 14, 2026

Copy link
Copy Markdown

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Drafted with Grok (xAI). I wrote and reviewed the formula, built it from source, ran brew test and brew audit --new --online --strict, and kept the commit author as myself.


Open-source Go CLI (Apache-2.0). Builds from the v0.29.1 source tarball. tmux is a runtime dependency. main.buildSource=Homebrew disables in-place self-update so upgrades stay on brew upgrade.

Notability: https://github.com/YoanWai/agent-manager — 312 stars, created 2026-07-15 (30 days). Self-submission.

A third-party tap cask already exists at yoanwai/tap/agent-manager for the prebuilt binary. This formula is the source build for brew install agent-manager.

@github-actions github-actions Bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Aug 14, 2026
Comment thread Formula/a/agent-manager.rb Outdated
Comment on lines +21 to +22
assert_match version.to_s, shell_output("#{bin}/agent-manager --version")
assert_match "usage: agent-manager rename", shell_output("#{bin}/agent-manager rename 2>&1", 1)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

  • Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
  • You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

  • If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
  • If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
  • If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
  • Same if the software requires a virtual machine, docker instance, etc. to be running.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick review! Swapped the usage check for tests that actually run the app:

  • pipes a JSON-RPC session into the built-in MCP server (initialize + tools/list) and checks the handshake reports the formula version (so the ldflags wiring too) and that the tool registry lists create_terminal
  • boots the TUI under a PTY and waits for the header to render, which also covers the tmux dependency since the app refuses to start without tmux on PATH

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants