deps: bump @hochfrequenz/efoli to ^2.0.0 - #973
Draft
hf-kklein wants to merge 1 commit into
Draft
Conversation
Picks up FV2704 and the validation changes in efoli.ts v2.0.0. Neither of v2.0.0's new throwing paths is reachable from this codebase, so no code change is needed: - getFormatVersionLabel (format-version-select.component.ts) only calls getEdifactFormatVersionLabel after checking membership in Object.values(EdifactFormatVersion), so it never passes a non-member. - resolveFormatVersion (server/service/validation.ts) parses an ISO date and already rejects impossible dates itself, via the same UTC round-trip efoli 2.0.0 now performs internally, raising ValidationError before efoli sees the value. Its ISO_DATE_PATTERN also constrains the year to four digits, inside efoli's new 1-9999 bound. Gates were not run locally: this repo requires node >=23.11.0 and only node 18 is available here. The lockfile was edited to the efoli entries alone rather than regenerated under the wrong npm, and the integrity hash was taken from the registry. CI runs on the right node. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hf-kklein
changed the title
github-actions
Bot
added
the
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves from
^0.0.9(which resolves to exactly 0.0.9) to^2.0.0, picking up FV2704 and the validation changes in efoli.ts v2.0.0.No code change needed — both new throwing paths are already guarded
efoli 2.0.0 throws where it previously returned a wrong answer. I checked each call site against that:
getFormatVersionLabel(format-version-select.component.ts:90) callsgetEdifactFormatVersionLabelonly afterObject.values(EdifactFormatVersion).includes(formatVersion), falling back to the raw string otherwise. It can never pass a non-member, which is the only input that now throws. (Without that guard this would have been the risky one: 0.0.9 returnedundefinedthere, and a??fallback would now throw instead.)resolveFormatVersion(server/service/validation.ts:76) parses an ISO date and rejects impossible ones itself —toCalendarDatedoes the same UTC round-trip efoli 2.0.0 now performs internally, raisingValidationErrorbefore efoli sees the value.ISO_DATE_PATTERNalso pins the year to four digits, inside efoli's new 1–9999 bound.So the externally-visible error contract is unchanged: malformed dates still surface as
ValidationError, not as an efoliError.KNOWN_FORMAT_VERSIONSis built fromObject.values(EdifactFormatVersion), so FV2704 becomes accepted input automatically with no edit.Gates were not run locally — please let CI be the judge
This repo requires
node >=23.11.0(.nvmrc:v23.11); only node 18 is available in my environment and no version manager is installed, so I did not install anything system-wide.test,lint,format:checkand the builds were not run by me.version/resolved/integrity. Regenerating under npm 9 would have introduced unrelated churn. Diff is 5 lines.integrityhash was read fromregistry.npmjs.orgfor 2.0.0, not typed by hand, and the lockfile was re-parsed as JSON afterwards.If CI is green this is safe to merge; if it is red, suspect the lockfile first and regenerate it on node 23.
🤖 Generated with Claude Code