Skip to content

fix(test): wait for the startup composer before pointer assertions #5979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hmbown wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

fix(test): wait for the startup composer before pointer assertions #5979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions crates/tui/tests/cucumber/active_composer_pointer_pty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,17 @@ fn run_pointer_submit_case(rows: u16, cols: u16) {
&format!("{size}: offline explore ready"),
);
tui.send(keys::key::enter()).expect("leave onboarding");
wait_or_panic(
&mut tui,
"New session",
// PTY reads can split a redraw: the launch header arrives before the
// composer, with onboarding rows still on screen (Buildkite #1861/#1867).
// Wait for the input surface as well as the header before asserting it.
tui.wait_for(
|frame| {
let text = frame.text();
text.contains("New session") && text.contains('❯') && !text.contains("You're ready.")
},
STARTUP_WAIT,
&format!("{size}: show the launch card"),
);
)
.unwrap_or_else(|error| panic!("{size}: show the launch card and composer: {error}"));
tui.pump();
assert_startup_contract(tui.frame(), rows, cols, &size);
// Typing goes straight to the composer; Enter sends the first message
Expand Down
Loading