Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/tui/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ codewhale-workflow = { path = "../workflow", version = "0.9.12" }
codewhale-workflow-js = { path = "../workflow-js", version = "0.9.12" }
async-stream = "0.3.6"
async-trait.workspace = true
base64 = "0.22.1"
base64 = "0.23.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING] MSRV raised to 1.71.0

base64 0.23.0 raises the minimum supported Rust version to 1.71.0. If this repository targets an earlier Rust version, CI or downstream builds will fail. Verify the workspace MSRV policy before merging.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING] Potential breaking change in DecodeError::InvalidLastSymbol

base64 0.23.0 changed DecodeError::InvalidLastSymbol to include the decoded value. Any exhaustive pattern match on DecodeError variants in the tui crate will need updating. The PR contains only manifest changes, so this was not verified by source edits; run cargo test -p codewhale-tui after merging/rebase.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[INFO] Default simd-unsafe feature now enabled

base64 0.23.0 adds SIMD-accelerated engines behind a default-on simd-unsafe feature. If dependency policy restricts unsafe code or default features are expected to be minimal, evaluate setting default-features = false and choosing an explicit engine.

axum.workspace = true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING] base64 0.23 raises MSRV to 1.71.0

The 0.23.0 release explicitly updates the minimum supported Rust version to 1.71.0. If this workspace supports older toolchains or has an MSRV policy below 1.71, this bump will break builds for those users/CI jobs. Confirm the workspace MSRV before merging.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[INFO] New default simd-unsafe feature

base64 0.23 introduces SIMD-accelerated engines behind the default-on simd-unsafe feature. This is generally fine, but it is a new default feature with unsafe code; if the project has strict safety/audit or no_std constraints, confirm it is acceptable.

clap.workspace = true
clap_complete.workspace = true
Expand Down
Loading