-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(providers): Concentrate as a first-class opt-in BYOK Responses gateway #5725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2860a57
feat(providers): Concentrate as a first-class opt-in BYOK Responses g…
689f52a
test(cli): bump the provider registry counts for Concentrate (48 / 43)
6fdcd52
Merge remote-tracking branch 'origin/main' into HEAD
823cf7b
Merge remote-tracking branch 'origin/main' into HEAD
55600f3
Merge remote-tracking branch 'origin/main' into feat/concentrate-prov…
0f09427
fix(providers): Concentrate review leftovers — alias, unauth 2xx, sel…
e4e8174
Merge origin/main into the Concentrate provider slice
9af679b
Merge remote-tracking branch 'origin/main' into feat/concentrate-prov…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ anthropic | |
| antigravity | ||
| arcee | ||
| atlascloud | ||
| concentrate | ||
| custom | ||
| deepinfra | ||
| deepseek | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[WARNING] Missing
concentrateaialias on Concentrate config table serde attributesProviderKind::Concentrate, the provideraliases()list, andsecrets::env_forall acceptconcentrateaias an alias, but theProvidersToml.concentratefield incrates/config/src/lib.rsand theProvidersConfig.concentratefield incrates/tui/src/config.rsonly declareconcentrate-aiandconcentrate_ai. A user selectingprovider = "concentrateai"and placing credentials under[providers.concentrateai]will have that table silently ignored (serde default ignores unknown fields), leaving the provider unconfigured. Add the missing alias to both serde attributes and add a regression test that parses[providers.concentrateai].There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0f09427: concentrateai serde alias is on both ProvidersToml.concentrate and ProvidersConfig.concentrate. [providers.concentrateai] now deserializes onto the concentrate table — pinned in concentrate_resolves_named_responses_gateway_and_environment_overrides (1 passed; 0 failed).