Add Claude Code GitHub Workflow - #4537
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @Hmbown's task in 2m 10s —— View job Review completeTodo list
SummaryThis PR is workflow-only (no product/Rust code touched), so the provider/model-route safety invariant doesn't apply here, and there's nothing for Main finding — duplicate automated review (see inline comment on The repo already has
Once merged, every future PR to
No other correctness, security, or reuse issues found in the two files. |
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, ready_for_review, reopened] |
There was a problem hiding this comment.
This duplicates the existing .github/workflows/claude-review.yml, which already runs an automated Claude review on the same pull_request: [opened, synchronize, reopened, ready_for_review] events (restricted to branches: [master, main]). Once this merges, every PR against main will get two separate automated Claude reviews, doubling API spend and posting redundant/conflicting comments.
The existing workflow is also more defensive than this one:
concurrency: { group: claude-review-${{ pr.number }}, cancel-in-progress: true }— this new workflow has none, so rapid pushes queue multiple concurrent paid runs on the same PR.if: github.event.pull_request.draft == false— this new workflow has no draft gate, so opening a draft PR triggers a full review immediately.- Graceful no-op (
HAS_OAUTHcheck) whenCLAUDE_CODE_OAUTH_TOKENis unset, so the job stays green instead of hard-failing. - A CodeWhale-specific review prompt (correctness, the v0.8.65 provider/model-route safety invariant, reuse, tests, security) vs. this workflow's generic upstream
code-review@claude-code-pluginsplugin, which has no context on this repo's conventions.
Suggest either dropping this file (keep the existing claude-review.yml as the PR-review workflow) or, if the plugin-based review is intentionally additive, porting over the concurrency group, draft gate, and secret-presence guard so it doesn't duplicate cost/noise.
Replace the generated broad Claude workflows with a maintainer-only issue command. The worker checks out main, serializes runs by issue, creates signed branches, and does not create or merge pull requests automatically. Retain the existing advisory Claude PR reviewer rather than adding a duplicate. Verification: actionlint .github/workflows/claude.yml; git diff --check; local command-gate regex cases. Agent assistance: Codex.
|
Claude finished @Hmbown's task in 1m 30s —— View job Review completeTodo list
SummaryThis push replaced the original generic templates with a purpose-built, tightly-scoped workflow ( The new design is a meaningful security improvement over a typical
Minor (non-blocking) — permission scope: No correctness bugs, provider/model-route safety issues (none of this logic touches model/provider selection), reuse problems, or missing-test concerns — this is a CI/workflow-only change with no product code path to unit test. |
The issue worker's GitHub operations (signed branch, commits, issue comments) run on the app token from the OIDC exchange, whose permission set is fixed in the exchange request — not on the workflow GITHUB_TOKEN. The job never creates or edits pull requests by design, so the workflow-level pull-requests: write grant was inert. Remove it per least-privilege review. Signed-off-by: Hunter B <hmbown@gmail.com>
|
Claude finished @Hmbown's task in 1m 17s —— View job Review completeTodo list
SummaryThis push ( I cross-checked the action inputs against the vendored
No correctness bugs, no provider/model-route safety concerns (workflow-only diff, no model/provider selection logic), and no duplication ( Nice tightening from the last round — this addresses every actionable item raised in the two prior reviews. No new issues found. |
Claude issue worker
This PR adds a deliberately bounded
@claudepath for maintainers to start work from a GitHub issue.What it enables after merge
A repository owner, member, or collaborator can add an exact
@claude <request>comment to an issue. Claude then works frommain, creates a signed branch namedclaude/issue-…, runs focused verification, and updates the triggering comment with the branch and a PR-creation link.Guardrails
OWNER,MEMBER, andCOLLABORATORcomments qualify; bots and look-alike mentions do not.claude-review.ymlremains the single advisory PR reviewer; this PR removes the redundant generated reviewer.Verification
actionlint .github/workflows/claude.ymlgit diff --check@claude-bot,@claudeish, and embedded mentions.First post-merge test
On a maintainer-owned small issue, comment:
Then use a small documentation-only issue to verify signed-branch creation and the PR-creation link before requesting substantive changes.