fix(web): regenerate facts.generated.ts for the two v0.9.8 providers - #5398
fix(web): regenerate facts.generated.ts for the two v0.9.8 providers#5398Lstarsky0 wants to merge 1 commit into
Conversation
|
Thanks @Lstarsky0 for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2825bf9e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "id": "antigravity", | ||
| "label": "Google Antigravity", | ||
| "env": "ANTIGRAVITY_API_KEY / AGY_ADC_AUTH" | ||
| }, |
There was a problem hiding this comment.
Exclude credential-only Antigravity from provider routes
When these facts render on the models page, every entry is presented and counted as a supported provider route, but crates/tui/src/client.rs rejects every Antigravity request because its wire protocol is unimplemented; adding this row therefore advertises a route that users cannot run and inflates the provider count across the homepage, FAQ, and facts API. Exclude Antigravity from the source derivation (or model credential-only entries separately) and regenerate this file rather than publishing it as a normal provider.
AGENTS.md reference: web/AGENTS.md:L5-L8
Useful? React with 👍 / 👎.
53af08c registered Google Gemini and 531b64e registered Google Antigravity, but web/lib/facts.generated.ts was never regenerated, so check:facts has been failing on main since the release. That gate is part of Lint & Type Check, which makes it a required check every web pull request inherits regardless of what it changes. Output of `cd web && npm run prebuild`, which is what the checker itself suggests. derive-facts.mjs reads the Rust sources directly and needs no build. The diff is the two provider rows plus generatedAt; the script preserves that stamp unless a checked fact moves, so it moving here is the signal that one did. Same family as Hmbown#5383 (assertion counts) and the docs/PROVIDERS.md row in Hmbown#5394 -- this is the remaining artifact those two commits left stale. Verified by hand: check:facts, check:locales, check:docs and lint all exit 0, run twice. vitest is unchanged at 10 failed / 250 passed, byte-identical to the same suite on an unmodified ad102ec -- seven Cloudflare deploy-preflight tests that need credentials, and three changelog and release-facts parity tests that this regeneration does not address. Analysis drafted with local tooling; every change and test verified by hand. No-Issue: unbreaks the check:facts gate on main; the drift itself is already covered by the v0.9.8 follow-ups.
f2825bf to
5bfc475
Compare
|
This clears Lint & Type Check runs Traced to three stale artifacts:
One thing that took checking and is easy to get backwards: The two The contributor ledger I've deliberately not touched. |
check:factshas been failing onmainsince v0.9.8, and it sits inside Lint & Type Check — a required check, so every web pull request inherits the red no matter what it touches. My #5397 is currently red on exactly this and nothing else.53af08ce3registered Google Gemini and531b64ed9registered Google Antigravity;web/lib/facts.generated.tswas never regenerated. Same pair that left the CLI assertion counts behind in #5383, and the same family as thedocs/PROVIDERS.mdrow #5394 refreshed — this looks like the remaining artifact from those two commits.This is the output of
cd web && npm run prebuild, which is what the checker prints as the remedy.derive-facts.mjsreads the Rust sources directly and needs no build.The diff is the two provider rows plus
generatedAt. The script deliberately preserves that stamp when no checked fact has moved, so it changing here is the signal that one did.Checks
Branched from
ad102ec44. Gates run twice, identical both rounds:npm run check:factsnpm run check:localesnpm run check:docsnpm run lintnpx vitest runstays at 10 failed / 250 passed, and the failing set is byte-identical to the same suite on an unmodifiedad102ec44— seven Cloudflare deploy-preflight tests that need credentials, plus onepublic-copyand twopublic-surface-contractparity tests. This regeneration does not address those three; they look like the changelog/release-facts side of the same v0.9.8 drift, and I did not want to bundle a guess with a mechanical regeneration.Analysis drafted with local tooling; every change and test verified by hand.
No-Issue: unbreaks the
check:factsgate on main; the drift itself is already covered by the v0.9.8 follow-ups.