ci(audit): point audit validator at our HTS terminology server (#183)#184
ci(audit): point audit validator at our HTS terminology server (#183)#184mauripunzueta wants to merge 2 commits into
Conversation
The audit-events workflow validated extracted AuditEvent codes against the public HL7 test server tx.fhir.org, which is rate-limited, sometimes unreachable, and outside our control. Point it at our own terminology server at hts.heliossoftware.com instead. - audit-events.yml: --tx-base-url -> https://hts.heliossoftware.com - validate_report.py: DEFAULT_TX_BASE_URL -> https://hts.heliossoftware.com, rename source id tx-r5-live-validation -> hts-live-validation, and generalize the report heading (the base URL is already printed below it). HTS serves terminology operations at the root (no /r4 or /r5 path segment) and needs no auth; $validate-code resolves the audit code systems (audit-event-type, restful-interaction, audit-event-action, audit-event-outcome). The hts.yml comparison oracle is intentionally left on tx.fhir.org as the source of truth.
Code review1 issue found. Bug: stale source name in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The source entry was renamed tx-r5-live-validation -> hts-live-validation, but the lookup in build_terminology_context() still checked the old name, making the per-run tx_base_url override dead code. With a custom --tx-base-url the report would show the stale default instead of the URL actually validated against.
|
@mauripunzueta When I ran this GitHub action on this branch, I'm seeing errors: https://github.com/HeliosSoftware/hfs/actions/runs/28484701168 |
smunini
left a comment
There was a problem hiding this comment.
I'm seeing errors: https://github.com/HeliosSoftware/hfs/actions/runs/28484701168
Summary
Part of #183 — migrate CI off the public HL7 test terminology server
tx.fhir.orgtoward our own server.The audit-events workflow validates extracted AuditEvent codes (
$validate-code) against a terminology server. It usedtx.fhir.org/r5, which is rate-limited, occasionally unreachable, and not under our control. This points that validation backend at our own terminology server,https://hts.heliossoftware.com.Changes
.github/workflows/audit-events.yml:--tx-base-url→https://hts.heliossoftware.comcrates/hfs/tests/audit/validate_report.py:DEFAULT_TX_BASE_URL→https://hts.heliossoftware.comtx-r5-live-validation→hts-live-validation### Terminology Server Validation); the actual base URL is already printed dynamically beneath itNotes
/r4or/r5path segment (those 404), and no auth required.hfs.heliossoftware.comis the FHIR server (hfsbinary, no terminology ops); the terminology server ishts.heliossoftware.com(htsbinary).$validate-codereturnsresult: truefor every code system the validator exercises —audit-event-type,restful-interaction,audit-event-action,audit-event-outcome.hts.ymlcomparison oracle is intentionally left ontx.fhir.org/r4+/r5as the source of truth. The fhirpathevaluator.rsdefaults (which feedtest_r5_test_suite) are also left ontx.fhir.orgsince those test expectations are oracle-derived.