Skip to content

Chip.add_cell: allow specifying the magnification of the added cell#61

Open
fbeutel wants to merge 1 commit into
HelgeGehring:masterfrom
fbeutel:add_cell_magnification
Open

Chip.add_cell: allow specifying the magnification of the added cell#61
fbeutel wants to merge 1 commit into
HelgeGehring:masterfrom
fbeutel:add_cell_magnification

Conversation

@fbeutel

@fbeutel fbeutel commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@HelgeGehring

Copy link
Copy Markdown
Owner

Thanks!
I think I left this parameter out, as not all functions are considering the value yet.
It should be implemented in

  • get_bonds
  • get_reduced_layer
  • save
  • get_patches
    to not cause inconsistencies.
    Before we add the parameter, I think we should implement it (or add a warning to the functions which ignore magnification if magnification is used)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants