perf: iterate counts[] in value_at_quantile to elide bounds checks#139
Closed
fcostaoliveira wants to merge 1 commit into
Closed
perf: iterate counts[] in value_at_quantile to elide bounds checks#139fcostaoliveira wants to merge 1 commit into
fcostaoliveira wants to merge 1 commit into
Conversation
…ds check Scan with counts.iter().enumerate() instead of indexing counts[i] in a 0..len loop, so the element is handed to the loop without a bounds check on the hot prefix-sum path. Results unchanged.
Author
|
Superseded by #140. That PR rewrites the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
value_at_quantileprefix-sum scan iterated withfor i in 0..self.counts.len()and indexedself.counts[i]. Iterating the slice directly withself.counts.iter().enumerate()hands theelement to the loop without a per-element bounds check on the hot path. Results are unchanged.
Benchmark
gnr1(Intel Granite Rapids), single core, same-session A/B:value_at_percentile(Mq/s)Percentile results byte-identical (the benchmark sink is unchanged).
cargo testgreen;cargo fmt --checkclean.