Remove all unsafe usage#137
Open
marshallpierce wants to merge 1 commit into
Open
Conversation
marshallpierce
force-pushed
the
mp/no-unsafe
branch
from
e7c488b to
22ddc28
Compare
Fixes #136. The unsafe usage in V2Serializer was only worth maybe ~5% speedup, assuming it was correct, which it was not... Past me did not worry enough about unsafe, apparently.
marshallpierce
force-pushed
the
mp/no-unsafe
branch
from
22ddc28 to
cdea092
Compare
Collaborator
Author
|
Coverage upload failed 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
The unsafe usage in V2Serializer was only worth maybe ~5% speedup, assuming it was correct, which it was not... Past me did not worry enough about unsafe, apparently.