[cpp] Optimise Bytes.ofString utf8#12585
Open
tobil4sk wants to merge 1 commit into
Open
Conversation
tobil4sk
force-pushed
the
fix/cpp-optimize-Bytes.ofString
branch
from
8d03e4c to
0bb8417
Compare
To use the current Utf8.encode method, we have to run getByteCount which iterates through the string to create a buffer which is the right size. However, since Utf8.encode is a public function, it has to validate that the size of the buffer is correct, which means it iterates through the string again. This new Utf8.encode method without a buffer argument creates its own array and returns it, avoiding the unnecessary check.
tobil4sk
force-pushed
the
fix/cpp-optimize-Bytes.ofString
branch
from
0bb8417 to
4f4d81f
Compare
Member
Author
|
@Simn @Aidan63 this is the haxe std side fix corresponding to HaxeFoundation/hxcpp#1306, and it will hopefully further improve performance for the text related benchmarks. The hl failure is likely related to HaxeFoundation/hashlink@b0c568a, and should disappear on ci rerun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use the current Utf8.encode method, we have to run getByteCount which iterates through the string to create a buffer which is the right size. However, since Utf8.encode is a public function, it has to validate that the size of the buffer is correct, which means it iterates through the string again.
This new Utf8.encode method without a buffer argument creates its own array and returns it, avoiding the unnecessary check.
This requires the method to be added to hxcpp: HaxeFoundation/hxcpp#1306.