Skip to content

Scripts: heavy cleanup - part 01 - #308

Merged
Hextv merged 1 commit into
HavenWoW:mainfrom
Xenphis:script_cleanup
Aug 16, 2026
Merged

Scripts: heavy cleanup - part 01#308
Hextv merged 1 commit into
HavenWoW:mainfrom
Xenphis:script_cleanup

Conversation

@Xenphis

@Xenphis Xenphis commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Changes Proposed:

This PR proposes changes to:

  • Scripts (bosses, spell scripts, creature scripts).

Changes:

  • Bad comment cleanup
  • Fix a large bunch of gcc errors
  • No functional changes

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

  • AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • MSVC Build only

Known Issues and TODO List:

  • Doesn't fixes all gcc issues. Need to done in several PR

How to Test BFA-HavenCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub.

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@Hextv
Hextv merged commit 1c25fc8 into HavenWoW:main Aug 16, 2026
2 checks passed
@Xenphis
Xenphis deleted the script_cleanup branch August 16, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants