Support 4.8 WireGuard and multiple clients - #65
Closed
Hertzole wants to merge 1 commit into
Closed
Conversation
Owner
|
to prevent it breaking, we need to make it vary behaviour based on firmware version - which is available from the router status call. |
Contributor
Author
|
I will refactor this and HarvsG/gli4py#21 to support that. |
Contributor
Author
|
Closing this as #66 fixes it instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the WireGuard integration for versions 4.8 and above, and fixes #57. This is a breaking change and won't support any older versions.
It also includes support for multiple WireGuard clients, which was introduced in 4.8. I am honestly not entirely sure this works as I don't have multiple clients to test with, but I think it will if I can trust my code.
I also changed the wireguard_clients dictionary to use ints instead of strings for keys as that is what I get from the config call.
This PR relies on HarvsG/gli4py#21 being merged and gli4py being updated, so I'll create it as a draft for now.