Skip to content

Update: Stable Diffusion v2 checkpoint link - #34

Merged
Haruko386 merged 1 commit into
mainfrom
test
Jul 27, 2026
Merged

Update: Stable Diffusion v2 checkpoint link#34
Haruko386 merged 1 commit into
mainfrom
test

Conversation

@Haruko386

@Haruko386 Haruko386 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

As title

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • CI / build change
  • Other

Summary by CodeRabbit

  • Documentation
    • Updated training setup instructions to download the Stable Diffusion v2.1 checkpoint instead of the older v2 checkpoint.

@Haruko386 Haruko386 added this to the ApDepth V2-1 milestone Jul 27, 2026
@Haruko386 Haruko386 self-assigned this Jul 27, 2026
@Haruko386 Haruko386 added 📑 documentation Improvements or additions to documentation ✨ enhancement New feature for better experience labels Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The README training prerequisites now download the Stable Diffusion 2-1 checkpoint instead of the older Stable Diffusion 2 checkpoint, with ${BASE_CKPT_DIR} unchanged.

Changes

Training checkpoint update

Layer / File(s) Summary
Stable Diffusion checkpoint URL
README.md
The training download link now targets the stable-diffusion-2-1 release while retaining ${BASE_CKPT_DIR}.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only repeats the title and omits required sections like Related Issue and Test Results. Add a real Summary, link the Related Issue or note none, and include Test Results per the template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: updating the Stable Diffusion v2 checkpoint link.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Haruko386 Haruko386 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Haruko386
Haruko386 merged commit a57e06c into main Jul 27, 2026
4 of 5 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in @ApDepth V2-1 Jul 27, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Line 198: Align the checkpoint directory referenced by the README download
step with the training path configured in config/model_sdv2.yaml: either update
pretrained_path to stable-diffusion-2-1 or document renaming/symlinking the
downloaded repository to stable-diffusion-2 under BASE_CKPT_DIR. Ensure the
trainer’s ${BASE_CKPT_DIR}/${pretrained_path} lookup resolves successfully.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 69235006-f0b4-4778-93df-aecb24d14c71

📥 Commits

Reviewing files that changed from the base of the PR and between 9033399 and c431550.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md
```

Download Stable Diffusion v2 [checkpoint](https://huggingface.co/sd2-community/stable-diffusion-2) into `${BASE_CKPT_DIR}`
Download Stable Diffusion v2 [checkpoint](https://huggingface.co/sd2-community/stable-diffusion-2-1) into `${BASE_CKPT_DIR}`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Keep the downloaded checkpoint directory aligned with the training config.

config/model_sdv2.yaml still sets pretrained_path: stable-diffusion-2, and the trainer loads ${BASE_CKPT_DIR}/${pretrained_path}. Downloading the stable-diffusion-2-1 repository without renaming or symlinking it will make training fail to find the checkpoint. Update the config in the same change, or explicitly document the required target directory name here.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 198, Align the checkpoint directory referenced by the
README download step with the training path configured in
config/model_sdv2.yaml: either update pretrained_path to stable-diffusion-2-1 or
document renaming/symlinking the downloaded repository to stable-diffusion-2
under BASE_CKPT_DIR. Ensure the trainer’s ${BASE_CKPT_DIR}/${pretrained_path}
lookup resolves successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📑 documentation Improvements or additions to documentation ✨ enhancement New feature for better experience

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant