Conversation
📝 WalkthroughWalkthroughThe README training prerequisites now download the Stable Diffusion 2-1 checkpoint instead of the older Stable Diffusion 2 checkpoint, with ChangesTraining checkpoint update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 198: Align the checkpoint directory referenced by the README download
step with the training path configured in config/model_sdv2.yaml: either update
pretrained_path to stable-diffusion-2-1 or document renaming/symlinking the
downloaded repository to stable-diffusion-2 under BASE_CKPT_DIR. Ensure the
trainer’s ${BASE_CKPT_DIR}/${pretrained_path} lookup resolves successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| ``` | ||
|
|
||
| Download Stable Diffusion v2 [checkpoint](https://huggingface.co/sd2-community/stable-diffusion-2) into `${BASE_CKPT_DIR}` | ||
| Download Stable Diffusion v2 [checkpoint](https://huggingface.co/sd2-community/stable-diffusion-2-1) into `${BASE_CKPT_DIR}` |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep the downloaded checkpoint directory aligned with the training config.
config/model_sdv2.yaml still sets pretrained_path: stable-diffusion-2, and the trainer loads ${BASE_CKPT_DIR}/${pretrained_path}. Downloading the stable-diffusion-2-1 repository without renaming or symlinking it will make training fail to find the checkpoint. Update the config in the same change, or explicitly document the required target directory name here.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 198, Align the checkpoint directory referenced by the
README download step with the training path configured in
config/model_sdv2.yaml: either update pretrained_path to stable-diffusion-2-1 or
document renaming/symlinking the downloaded repository to stable-diffusion-2
under BASE_CKPT_DIR. Ensure the trainer’s ${BASE_CKPT_DIR}/${pretrained_path}
lookup resolves successfully.
Summary
As title
Type of Change
Summary by CodeRabbit