Skip to content

enhance: support reading subfolders - #31

Merged
Haruko386 merged 1 commit into
mainfrom
moon
Jul 17, 2026
Merged

enhance: support reading subfolders#31
Haruko386 merged 1 commit into
mainfrom
moon

Conversation

@Haruko386

@Haruko386 Haruko386 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Related to #18

Summary by CodeRabbit

  • New Features

    • Added recursive discovery of supported image files within input directories.
    • Preserved input folder structure when saving depth predictions, including NumPy, grayscale PNG, and colored PNG outputs.
  • Bug Fixes

    • Prevented non-file paths and unsupported file types from being processed.

@Haruko386 Haruko386 self-assigned this Jul 17, 2026
@Haruko386 Haruko386 added ✨ enhancement New feature for better experience 💫 feature New feature labels Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 650705bb-0d60-4070-b3f7-2d978207b322

📥 Commits

Reviewing files that changed from the base of the PR and between 094c03b and 1cac553.

📒 Files selected for processing (1)
  • run.py

📝 Walkthrough

Walkthrough

run.py now discovers supported images recursively, excludes non-files, and preserves each image’s relative directory structure when saving NumPy, 16-bit PNG, and colored PNG predictions.

Changes

Recursive inference output

Layer / File(s) Summary
Recursive image discovery
run.py
Image discovery now traverses input_rgb_dir recursively, keeps regular files only, and filters supported extensions case-insensitively.
Mirrored prediction output
run.py
NumPy, 16-bit PNG, and colored PNG predictions are saved in nested output directories matching each input image’s relative parent directory. Existing-file warnings target the nested paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only links an issue and omits the required Summary, Type of Change, and Test Results sections. Add the missing template sections: Summary, Type of Change, and Test Results, and briefly describe the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: recursive subfolder input support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • ✅ Generated successfully - (🔄 Check to regenerate)
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch moon

Comment @coderabbitai help to get the list of available commands.

@Haruko386 Haruko386 added this to the ApDepth V2-1 milestone Jul 17, 2026
@Haruko386
Haruko386 merged commit 969a011 into main Jul 17, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in @ApDepth V2-1 Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Caution

Docstrings generation - FAILED

No docstrings were generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement New feature for better experience 💫 feature New feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feature] Automatically traverse the entire folder when inferring images

1 participant