Repository navigation
docs(parity): notes for the first 25 shipped features - #9
Open
Harrison-Booth wants to merge 230 commits into
Open
Harrison-Booth wants to merge 230 commits into
Harrison-Booth wants to merge 230 commits into
Conversation
Use the fixed release for GHSA-vc25-qg58-w57c.
* Refactor annot for strict Clippy checks * Refactor automation for strict Clippy checks * Refactor cos for strict Clippy checks * Refactor edit for strict Clippy checks * Refactor engine for strict Clippy checks * Refactor export for strict Clippy checks * Refactor forms for strict Clippy checks * Refactor js for strict Clippy checks * Refactor organize for strict Clippy checks * Refactor pdfcraft-cli for strict Clippy checks * Refactor preflight for strict Clippy checks * Refactor print for strict Clippy checks * Refactor redact for strict Clippy checks * Refactor render for strict Clippy checks * Refactor sign for strict Clippy checks * Refactor ui canvas for strict Clippy checks * Refactor ui commands for strict Clippy checks * Refactor ui dialogs for strict Clippy checks * Refactor ui support for strict Clippy checks * Refactor ui tools for strict Clippy checks * Refactor ui workflows for strict Clippy checks * Refactor xfa for strict Clippy checks * Refactor xfdf for strict Clippy checks * Enforce workspace Clippy standards and document lint policy * Fix menu overflow and form pointer handling * Group annotation, form and document operation parameters * Group signing and timestamp validation inputs * Group demo form field properties * Group UI interaction and rendering parameters * Restore translated security and shortcut labels * Fix platform-gated imports for Windows and wasm builds * Qualify signing calls for macOS and Windows builds * Restore the preflight check flow and the overflow menu title
storytold#5094) craft-libs#366 drops the default-features override on craft-keymap that older Cargo rejects. FreeBSD aarch64 builds with Rust 1.98.1 and failed with "no matching package named craft-menu found" (craft-libs#364).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
78 shipped entries in
parity/acrobat-features.tomlhad emptynotes, although CLAUDE.md asks every shipped feature to say what is still missing. This fills in the first 25 (the 21core.*ones, thenview.render-error-isolation,view.render-priority,view.rotate-view,view.page-labels-display), one or two plain sentences each.cargo xtask paritynow also prints a warning, not an error, listing shipped entries with empty notes (53 remain).Provenance of the notes. Every note was written from reading the code and the cited tests, plus what
docs/says. Real Acrobat was not available and no Acrobat behaviour is claimed. Nothing was run to confirm a note beyond the code reading, so all 25 are inferred from code and tests, not from running the features. Where a note says Acrobat DC opened our output, that is quoted fromdocs/file-format-parity.md. Notes that name a gap (for example R5 untested, unknown/CFMread as Identity, cited tests that only use our own writer's files) are what I found missing in the cited evidence, not a confirmed defect.How you verified it
cargo fmt --check -p xtask: cleancargo clippy -p xtask --all-targets -- -D warnings: cleancargo test -p xtask parity: 3 passedcargo run -p xtask -- parity: the manifest parses and validates; the new warning lists the 53 remaining entriesCARGO_BUILD_JOBS=2, xtask only. Only Linux ran locally; the change is a data file and one xtask report, so I did not run Windows or macOS builds, and no GUI or Excel check applies.main(branchpc-parity-notes-base) so the diff shows only these two files.Tests. The xtask change is a report line; it is exercised by running
cargo xtask parity(it printed the warning for the 53 remaining entries) and the existing parity tests still pass. I did not add a unit test for the warning.Never-crash
No new
unwrap/expect/panic, indexing,unsafeor input-sized allocation: the xtask addition filters and joins the manifest's own ids. It is dev tooling, not product code.Provenance
Text and one xtask report only. No asset, font or copied code. Behaviour descriptions come from this repository's code, tests and docs; no Acrobat observation.
Security
Not applicable: no
--root, MCP, control-channel or network change.Parity and reach
parity/acrobat-features.tomlis the file changed; the notes say what is still missing. No automation tool applies (documentation and a dev report).Anything a reviewer should look at first
Please check the notes that name a gap against the code: R5 is accepted but not generated by the cited tests, an unknown
/CFMreads as Identity, and several cited tests use only files our own writer produced.