ci: raise go test -race timeout to 900s - #749
Open
remyluslosius wants to merge 1 commit into
Open
Conversation
The internal/server suite (~470s without -race) rides near the old per-package 600s limit under `go test -race -p 4`, so it intermittently times out on slower / more-contended runners — e.g. Go CI #976 on main (post-#748 merge) timed out at 10m0s while the identical commit passed on the PR branch. Recent test additions pushed it over the edge. Raise the per-package timeout to 900s for headroom; a genuine hang still fails within 15 min.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Go CI #976 on
main(the push after #748 merged) failed with:The identical commit passed as Go CI #975 on the PR branch — so it's a timeout/resource flake, not a regression. The
internal/serversuite (~470s without-race) rides right at the old per-package 600s limit undergo test -race -p 4with shared-Postgres contention; recent test additions (v0.6.0 lens-default / trend / api tests) pushed it over on the slower main runner.Change
.github/workflows/go-ci.yml:go test -race … -timeout 600s→900s. Per-package timeout, so it gives the heavyinternal/serversuite headroom; a genuine hang still fails within 15 min. No job-leveltimeout-minutesis set, so the job won't be killed early.Follow-up (not in this PR)
If the suite keeps growing, the more durable fix is to split
internal/serveror scope-racemore narrowly rather than raising the timeout again.🤖 Generated with Claude Code