Skip to content

Fix temporal filter handling and validation - #66

Merged
michaelhallquist merged 1 commit into
mainfrom
codex/review-temporal_filter-parameters-usage
Sep 24, 2025
Merged

michaelhallquist merged 1 commit into
mainfrom
codex/review-temporal_filter-parameters-usage

Conversation

@michaelhallquist

Copy link
Copy Markdown
Contributor

Summary

  • correct the temporal filter high-pass sentinel so low-pass-only filtering works and document the expected behaviour
  • improve the setup prompts and project validation logic for temporal filter cutoffs
  • add regression tests covering the bptf argument handling and band-pass validation and refresh the manual entry

Testing

  • Rscript -e 'devtools::test()' (fails: missing packages corpcor, lgr, RNifti, signal in the container)

https://chatgpt.com/codex/tasks/task_e_68d30e8c1d948321bd7daf2f4965e61b

@michaelhallquist
michaelhallquist merged commit 3c41ec7 into main Sep 24, 2025
1 of 6 checks passed
@michaelhallquist
michaelhallquist deleted the codex/review-temporal_filter-parameters-usage branch September 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant