Adds desktop authentication flow#27
Merged
Merged
Conversation
Collaborator
Author
|
To do:
|
Implements a token refresh mechanism for the web authentication strategy. This allows the application to obtain new access tokens using a refresh token, improving security and user experience by reducing the need for frequent re-authentication.
Ensures consistent timestamp generation across different parts of the authentication strategy, aligning with the original client implementation. This resolves potential issues with credential expiry checks that could arise from inconsistent timestamp handling.
These methods need dynamic control over their return values. These are backward breaking changes, but only for private methods.
tayden
force-pushed
the
desktop-flow
branch
from
September 12, 2025 23:07
6627500 to
946f819
Compare
tayden
marked this pull request as ready for review
September 15, 2025 15:24
Collaborator
Author
|
This is good to go! It's pretty slick.
|
tayden
force-pushed
the
desktop-flow
branch
from
September 15, 2025 19:23
e3fdd20 to
3534ec2
Compare
tayden
force-pushed
the
desktop-flow
branch
from
September 15, 2025 20:00
5887f7a to
9559e74
Compare
boshek
approved these changes
Sep 15, 2025
boshek
left a comment
Contributor
There was a problem hiding this comment.
This looks great. I tried it out locally at it worked perfectly. And the code is rock solid. What a great improvement. One non-blocking thought here is whether we should start including a changelog or release notes here.
thanks for the all tests too!
Co-authored-by: Sam Albers <sam.albers@hakai.org>
Co-authored-by: Sam Albers <sam.albers@hakai.org>
Contributor
|
I believe this also closes #26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the desktop login flow for more seamless API authorization in desktop apps. Users will no longer be required to copy and paste credentials.
This needs more work, but is functional as is.