Skip to content

Prep for 0.3.2 - #6

Merged
HaivuUK merged 4 commits into
mainfrom
fix/file-read-fragility
Jul 22, 2026
Merged

Prep for 0.3.2#6
HaivuUK merged 4 commits into
mainfrom
fix/file-read-fragility

Conversation

@HaivuUK

@HaivuUK HaivuUK commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Fix for ansys cdb file fragility.
Doc updates.
Added logo test files, that make a colour distribution similar to the LUMA logo.

Proposed changes

  1. This pull request has important fixes for the ANSYS cdb file reader that prevent node read errors from a fragile set of if statements that compare part lengths that could not really capture all arrangements sensibly.

  2. Documentation has had slight readability updates.

  3. A public test has been added that allows the LUMA logo to be generated by the software.

Types of changes

What types of changes does your code introduce to LUMA?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have tested the code locally
  • I have added the necessary documentation (if appropriate)

Fix for ansys cdb file fragility.
Doc updates.
Added logo test files, that make a colour distribution similar to the LUMA logo.
@HaivuUK HaivuUK self-assigned this Jul 22, 2026
@HaivuUK HaivuUK linked an issue Jul 22, 2026 that may be closed by this pull request
@HaivuUK HaivuUK added bug Something isn't working documentation Improvements or additions to documentation labels Jul 22, 2026
@HaivuUK

HaivuUK commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

This now also closes #5

@HaivuUK HaivuUK linked an issue Jul 22, 2026 that may be closed by this pull request
Also bump cargo update.
@HaivuUK

HaivuUK commented Jul 22, 2026

Copy link
Copy Markdown
Owner Author

Fixes tests on windows by bundling common-controls for tests

@HaivuUK
HaivuUK merged commit d21c062 into main Jul 22, 2026
3 checks passed
@HaivuUK
HaivuUK deleted the fix/file-read-fragility branch July 22, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to open a vtk file with the scalars type scalars unsigned_char 1 Ansys reader fails when node value is not spaced

1 participant