Prep for 0.3.2 - #6
Merged
Merged
Conversation
Fix for ansys cdb file fragility. Doc updates. Added logo test files, that make a colour distribution similar to the LUMA logo.
Owner
Author
|
This now also closes #5 |
Also bump cargo update.
Owner
Author
|
Fixes tests on windows by bundling common-controls for tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for ansys cdb file fragility.
Doc updates.
Added logo test files, that make a colour distribution similar to the LUMA logo.
Proposed changes
This pull request has important fixes for the ANSYS cdb file reader that prevent node read errors from a fragile set of if statements that compare part lengths that could not really capture all arrangements sensibly.
Documentation has had slight readability updates.
A public test has been added that allows the LUMA logo to be generated by the software.
Types of changes
What types of changes does your code introduce to LUMA?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.