Skip to content

Additional ROI shapes (0.3.7) - #12

Open
HaivuUK wants to merge 2 commits into
mainfrom
feat/new-phantom-roi-shapes
Open

Additional ROI shapes (0.3.7)#12
HaivuUK wants to merge 2 commits into
mainfrom
feat/new-phantom-roi-shapes

Conversation

@HaivuUK

@HaivuUK HaivuUK commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Proposed changes

  • Refactor of the ROI code.
  • Cylinder ROI.
  • Nodal ROI.

Fixes #10

Types of changes

What types of changes does your code introduce to LUMA?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have tested the code locally
  • I have added the necessary documentation (if appropriate)

refactor of the calibrator.js and index.html to support more shapes.
improvements to the documentation.
@HaivuUK HaivuUK self-assigned this Aug 11, 2026
@HaivuUK HaivuUK added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 11, 2026
@HaivuUK

HaivuUK commented Aug 11, 2026

Copy link
Copy Markdown
Owner Author

Currently the rust side is not built and needs to be added to actually get any values for the calibration.
The UI needs to be fixed because it isn't super helpful right now and the sizing is a mess.

And removal of an unused function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phantom Calibration ROIs cannot be altered once a new one is placed

1 participant