fix: unbreak the Week 9 assignment template (CI startup + grader false-negatives)#4
Open
lassebenni wants to merge 2 commits into
Open
fix: unbreak the Week 9 assignment template (CI startup + grader false-negatives)#4lassebenni wants to merge 2 commits into
lassebenni wants to merge 2 commits into
Conversation
…tartup Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…alified views Same fix merged into the c55-data-week-9 cohort fork (PR #8): file_is_filled no longer fails on any TODO (strips SQL comments, only flags start-of-line placeholders), and vw_dim_zones/vw_fact_trips detection allows a schema prefix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in the Week 9 assignment template so cohort forks don't inherit them. Both were found and fixed in the live cohort fork
c55-data-week-9(grader fix merged there as PR #8); this brings the template into line.1. CI never runs (
grade-assignment.yml)The
gradejob granted onlyissues: write+pull-requests: write, which forcescontents: none. The reusableauto-grade.yml@mainneedscontents: read(checkout), so GitHub rejects it at load time →startup_failure, 0 jobs. Fix: addcontents: read(matches the workingc55-data-week-6).2. Grader fails correct submissions (
.hyf/test.sh)file_is_filled()failed any file containing the word "TODO", so students who left the scaffold's-- TODO:guide comments above finished, correct queries scored as empty stubs. Now it strips SQL comments and only flags a line whose content begins with TODO.vw_dim_zones/vw_fact_tripsdetection missed schema-qualified names (dev_x.vw_dim_zones) — the own-schema pattern the assignment requires. The regex now allows a<schema>.prefix.Verified in the cohort fork against 7 real student PRs: scores went
15/30/15/15/85/30/95→100/100/95/95/100/100/95, with genuine gaps still caught.bash -npasses.🤖 Generated with Claude Code