completed SQL queries#3
Open
thebaraah wants to merge 1 commit into
Open
Conversation
jrnhofman
reviewed
Jul 6, 2026
| -- TODO | ||
| vendor_id, | ||
| pickup_datetime::TIMESTAMP AS pickup_datetime, | ||
| dropoff_datetime, |
There was a problem hiding this comment.
It was not in the assignment but it's best to cast all similar columns to similar type, i.e. cast this one to datetime as well.
jrnhofman
approved these changes
Jul 6, 2026
jrnhofman
reviewed
Jul 6, 2026
|
|
||
| TODO: What were you trying to solve? Paste the relevant SQL or schema fragment. | ||
|
|
||
| CREATE OR REPLACE VIEW vw_dim_zones AS |
There was a problem hiding this comment.
make sure to specify a schema as well so you don't write all your tables in the public schema that is potentially shared with others!
jrnhofman
reviewed
Jul 6, 2026
| GROUP BY d.borough | ||
| ORDER BY trip_count DESC; | ||
| SELECT | ||
| pickup_location_id, |
There was a problem hiding this comment.
not wrong, but this just gives you the IDs, how would you create pairs of zone names instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.