Add Parse method to DurationTimeParser - #6
Merged
Conversation
Introduced a `Parse` method to validate and convert input strings to `TimeSpan`, throwing relevant exceptions (`ArgumentNullException`, `FormatException`) for invalid cases. This method was introduced for not passive coding approaches to satisfy this possible need of developers too. Added comprehensive unit tests to cover the new method `Parse` functionality. To avoid input value redundancy and enhance reusability, all values were extracted to use-case dedicated classes.
Added benchmarks for the new method `Parse` and hide not needed columns "Job" and "Alloc Ratio" in results.
The usage examples in the README file were fixed and a reference to the Benchmark page in the Wiki added. The later was done to keep the README small and focused on the easy get started.
HaGGi13
added a commit
that referenced
this pull request
Feb 22, 2026
Add `Parse` method to `DurationTimeParser` Introduced a `Parse` method to validate and convert input strings to `TimeSpan`, throwing relevant exceptions (`ArgumentNullException`, `FormatException`) for invalid cases. This method was introduced for not passive coding approaches to satisfy this possible need of developers too. Added comprehensive unit tests to cover the new method `Parse` functionality. To avoid input value redundancy and enhance reusability, all values were extracted to use-case dedicated classes. Extend benchmarks Furthermore, benchmarks for the method `Parse` were added. In addition, the usage examples in the README file were fixed and a reference to the Benchmark page in the Wiki added. The later was done to keep the README small and focused on the easy get started. Added benchmarks for the new method `Parse` and hide not needed columns "Job" and "Alloc Ratio" in results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Parsemethod toDurationTimeParserIntroduced a
Parsemethod to validate and convert input strings toTimeSpan, throwing relevant exceptions (ArgumentNullException,FormatException) for invalid cases.This method was introduced for not passive coding approaches to satisfy
this possible need of developers too.
Added comprehensive unit tests to cover the new method
Parsefunctionality. To avoid input value redundancy and enhance reusability,
all values were extracted to use-case dedicated classes.
Extend benchmarks
Furthermore, benchmarks for the method
Parsewere added.In addition, the usage examples in the README file were fixed and a
reference to the Benchmark page in the Wiki added. The later was done to
keep the README small and focused on the easy get started.
Added benchmarks for the new method
Parseand hide not needed columns"Job" and "Alloc Ratio" in results.