Optimize regex usage + improve parsing performance - #5
Merged
Conversation
Removed redundant `RegexOptions.Compiled` flag from the `GeneratedRegex` attribute because the source generator produces by default an already optimized RegEx at compile time. Replaced `.Value` with `.ValueSpan` to minimize string allocation and enhance performance during parsing. Cached frequently accessed `Group` instances to avoid redundant lookups. Updated exception handling in parsing methods to specify relevant exceptions (`FormatException` and `OverflowException`).
Improved README formatting and grammar. Added usage examples for both human-readable and standard duration formats. Updated benchmark results to reflect changes in performance.
HaGGi13
added a commit
that referenced
this pull request
Feb 22, 2026
Optimize regex usage + improve parsing performance Removed redundant `RegexOptions.Compiled` flag from the `GeneratedRegex` attribute because the source generator produces by default an already optimized RegEx at compile time. Replaced `.Value` with `.ValueSpan` to minimize string allocation and enhance performance during parsing. Cached frequently accessed `Group` instances to avoid redundant lookups. Updated exception handling in parsing methods to specify relevant exceptions (`FormatException` and `OverflowException`). Improved README formatting and grammar. Added usage examples for both human-readable and standard duration formats. Updated benchmark results to reflect changes in performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize regex usage + improve parsing performance
Removed redundant
RegexOptions.Compiledflag from theGeneratedRegexattribute because the source generator produces by default an already
optimized RegEx at compile time.
Replaced
.Valuewith.ValueSpanto minimize string allocation andenhance performance during parsing.
Cached frequently accessed
Groupinstances to avoid redundant lookups.Updated exception handling in parsing methods to specify relevant
exceptions (
FormatExceptionandOverflowException).Improved README formatting and grammar.
Added usage examples for both human-readable and standard duration
formats.
Updated benchmark results to reflect changes in performance.