Skip to content

create multiple parallel but offset runners for kiosk highlighting - #24

Open
MaikRe wants to merge 4 commits into
HULKs:mainfrom
MaikRe:multi-image-highlight
Open

create multiple parallel but offset runners for kiosk highlighting#24
MaikRe wants to merge 4 commits into
HULKs:mainfrom
MaikRe:multi-image-highlight

Conversation

@MaikRe

@MaikRe MaikRe commented Jul 21, 2025

Copy link
Copy Markdown

Why? What?

Support multiple images being highlighted at one using multiple concurrent runners

Fixes #9

ToDo / Known Issues

  • Correctly determine region that will be blocked by highlighted image and prevent other runners from using this area

Ideas for Next Iterations (Not This PR)

  • Currently all of the runners will wait if their target area is blocked and try again next time it would be their turn.
    While this ensures that the animation frequency remains consistent (on average an image pops up every totalDuration / numWorkers seconds, it might be worth considering if this is the desired behavior.
  • Currently each worker chooses its target insertion area randomly, respecting only blocked rows but waiting until it can fill its target area no matter what. It should be considered if this is the desired behavior.
  • The number of workers should scale with screensize/number of rows, similar to the behavior desired by Automatically select number of rows depending on screen size #10

How to Test

  • Set yoursecret in yaml
  • Docker compose up
  • Go to 0:0:0:0:3000:kiosk.html#yoursecret
  • There need to be enough images uploaded in order to fill the full screen
  • Observe multiple images popped out and highlighted at a time

@MaikRe
MaikRe marked this pull request as ready for review July 21, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight multiple images at once

1 participant