Skip to content

Support release staging across versions #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olegberman merged 1 commit into from
Jul 28, 2026
Merged

Support release staging across versions #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,9 +334,8 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
steps:
- name: Remove the failed draft and its temporary tag
- name: Remove the failed draft
run: >-
gh release delete "v${{ needs.candidate.outputs.version }}"
--repo "${{ github.repository }}"
--cleanup-tag
--yes
12 changes: 8 additions & 4 deletions test/e2e/staging/lifecycle.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,23 @@ test("HQBase web lifecycle remains healthy", async ({ page, request }) => {
login.ok(),
`Owner API sign-in failed (${login.status()}): ${await login.text()}`
).toBeTruthy();
const newEmail = page.getByRole("button", { name: "New email" });
const primaryEmailAction = page.getByRole("button", {
name: /^(?:Compose|New email)$/
});
const loginEmail = page.getByLabel("Email");
try {
await page.goto("/", { waitUntil: "domcontentloaded" });
await expect(
loginEmail.or(newEmail),
loginEmail.or(primaryEmailAction),
"HQBase app shell renders its authenticated state"
).toBeVisible({ timeout: 60_000 });
} catch (error) {
const shell = await page.evaluate(() => ({
path: window.location.pathname,
rootChildren: document.querySelector("#root")?.childElementCount ?? -1,
scripts: [...document.scripts].map((script) => new URL(script.src).pathname),
scripts: [...document.scripts].map((script) =>
script.src ? new URL(script.src).pathname : "(inline)"
),
title: document.title
}));
console.error("HQBase app shell diagnostics", { appShellErrors, shell });
Expand All @@ -101,7 +105,7 @@ test("HQBase web lifecycle remains healthy", async ({ page, request }) => {
await page.getByLabel("Password").fill(password);
await page.getByRole("button", { name: "Continue" }).click();
}
await expect(newEmail).toBeVisible({ timeout: 60_000 });
await expect(primaryEmailAction).toBeVisible({ timeout: 60_000 });
const expectedUpdate = process.env.HQBASE_STAGING_EXPECT_UPDATE_VERSION;
if (expectedUpdate) {
await expect
Expand Down