fix(dev): restore local backend and frontend startup - #274
Draft
pengpengyi92 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two local-development blockers reported in #271:
email-validator, which is required by PydanticEmailStrmodels;/apirequests to the local FastAPI server on port 8000.Root cause
The backend requirements installed base Pydantic without the optional email validation dependency, causing application startup to fail when
EmailStrmodels were imported.The frontend uses a relative
/apibase, but the Vite development server had no proxy configured, so local API calls were sent to port 3000 instead of the FastAPI backend on port 8000.Impact
A clean local setup can now:
email-validatorerror;/apirequests to the backend on port 8000.Production behavior is unchanged because the proxy applies only to the Vite development server.
Validation
service/requirements.txt;EmailStrmodel import and validation;/docsand/openapi.jsonreturn 200 throughTestClient;/api/trendingrequest forwarded by Vite from port 3000 to a verification server on port 8000 and returned 200.Environment note
On Windows,
npm run buildcompletestscandvite buildsuccessfully and writesdist, then the repository's existing Unix-onlypostbuildcommand (chmod -R a+rX dist) returns an error becausechmodis unavailable. This PR does not change that unrelated script.Closes #271.