CI: restrict review-checklist workflows to HDFGroup/hdf5 only#6515
Merged
brtnfld merged 1 commit intoJul 9, 2026
Merged
Conversation
These workflows use pull_request_target / workflow_run with elevated permissions (pull-requests: write, issues: write). Because GitHub copies workflow files into forks, any fork with Actions enabled was independently running these privileged workflows against its own PRs, e.g. sp26-hdfgroup#2. Add the same github.repository == 'HDFGroup/hdf5' guard already used in review-checklist-test.yml so the job-level if short-circuits before doing anything in a fork's copy of the workflow.
brtnfld
requested review from
glennsong09,
hyoklee,
jhendersonHDF and
lrknox
as code owners
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
vchoi-hdfgroup
added
the
github_actions
hyoklee
approved these changes
Jul 9, 2026
github-project-automation
Bot
moved this from To be triaged
to Done
in HDF5 - TRIAGE & TRACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review-checklist.ymlandreview-checklist-gather.ymlusepull_request_target/workflow_run/pull_request_reviewtriggers with elevated permissions (pull-requests: write,issues: write).github.repository == 'HDFGroup/hdf5'to both jobs'if:conditions, matching the guard already used inreview-checklist-test.yml, so the job short-circuits before doing anything when running from a fork's own copy.